PR to src/search.js Typescript Translation#62
Open
Cedgo1997 wants to merge 32 commits intoUSB-CI3715:f24from
Open
PR to src/search.js Typescript Translation#62Cedgo1997 wants to merge 32 commits intoUSB-CI3715:f24from
Cedgo1997 wants to merge 32 commits intoUSB-CI3715:f24from
Conversation
- GetSearchCids typed - sortPosts typed
- Create new interceptor exppression in getSearchCids to convert categories into number before calling uniq method
- Updated utils.js adding elapsedTimeSince as method to use without process
- @typescript-eslint/no-unsafe-argument - @typescript-eslint/no-unsafe-assignment - @typescript-eslint/no-unsafe-return - No way to get over these errors
Merging f24 last commits to current branch
PR to src/search.js Typescript Translation
Pull Request Test Coverage Report for Build 11335377244Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for the Issue #1
This pull request introduces a transition from JavaScript to TypeScript in our project, focusing on enhancing type safety, code readability, and maintainability.
The new implementation utilizes explicit type annotations for function parameters and return types, which ensures that the correct data types are used throughout the code.
The updated code introduces interfaces and type definitions to clearly define the shape of objects. This promotes better documentation and understanding of the codebase. Some of the new interfaces are in the interfaces directory located in src/interfaces, these are: ISearchData, IPost, ITopic, and ITag.
Some eslint features were disabled, I experimented some problems caused by javascript imports and error handling with async/await, disabling these rules allows us to maintain functionality while we gradually migrate the codebase to fully utilize TypeScript’s features.
I needed to make some changes on tests so they could be covered.